[Cleanup] Moving a bunch of classes into android package (pt3). #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Code Coverage 76.89% ✅
Generated by 🚫 Danger |
Laimiux
commented
May 17, 2021
| - Move `FragmentLifecycleEvent` into `android.events` package. | ||
| - Move `Integration` into `android` package. | ||
| - Move `FragmentLifecycleCallback` into `android` package. | ||
| - Move `FragmentComponent` into `android` package. |
There was a problem hiding this comment.
I accidentally merged #205 into this PR as well. Sorry @Jawnnypoo
Jawnnypoo
approved these changes
May 17, 2021
Laimiux
added a commit
that referenced
this pull request
May 17, 2021
* Move FragmentKey into android package. * Moving a couple classes to android package. * Move BaseFormulaFragment into android package. * Move DisposableScope into android package. * Hiding Binding classes from public API. * Move AppManager into android.internal package. * [Cleanup] Moving a bunch of classes into android package (pt3). (#204) * Move BackCallback into android package. * Move FragmentLifecycleEvent into android.events package. * Move Integration into android package. * Move remaining fragments classes into android package. (#205)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moving a bunch of classes into the
androidpackage.